T3T1: use internal framebuffer #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TychoVrahe
added
T3T1
core
TychoVrahe
force-pushed
the
tychovrahe/T3T1/hw_support_framebuffer
branch
2 times, most recently
from
08173f1
to
a5afc16
Compare
TychoVrahe
force-pushed
the
tychovrahe/T3T1/hw_support_hash2
branch
from
977d437
to
897665e
Compare
TychoVrahe
force-pushed
the
tychovrahe/T3T1/hw_support_framebuffer
branch
from
a5afc16
to
81a07c5
Compare
TychoVrahe
force-pushed
the
tychovrahe/T3T1/hw_support_hash2
branch
from
897665e
to
fdb7265
Compare
TychoVrahe
force-pushed
the
tychovrahe/T3T1/hw_support_framebuffer
branch
from
cdbce7f
to
765696a
Compare
Hannsek
added
the
blocked
TychoVrahe
force-pushed
the
tychovrahe/T3T1/hw_support_hash2
branch
from
fdb7265
to
fcd60c5
Compare
TychoVrahe
force-pushed
the
tychovrahe/T3T1/hw_support_framebuffer
branch
from
e632bf5
to
de41967
Compare
TychoVrahe
force-pushed
the
tychovrahe/T3T1/hw_support_hash2
branch
from
fcd60c5
to
b4723ac
Compare
Base automatically changed from
tychovrahe/T3T1/hw_support_hash2
to
tychovrahe/u5/basic_support
February 5, 2024 14:47
TychoVrahe
force-pushed
the
tychovrahe/T3T1/hw_support_framebuffer
branch
2 times, most recently
from
374bf84
to
7ea36af
Compare
TychoVrahe
force-pushed
the
tychovrahe/u5/basic_support
branch
from
fd714ec
to
aba4848
Compare
TychoVrahe
removed
the
blocked
TychoVrahe
force-pushed
the
tychovrahe/T3T1/hw_support_framebuffer
branch
from
7ea36af
to
140bb5b
Compare
cepetr
approved these changes
Feb 28, 2024
TychoVrahe
force-pushed
the
tychovrahe/u5/basic_support
branch
2 times, most recently
from
0c0ba61
to
355caba
Compare
[no changelog]
[no changelog]
…y controller) [no changelog]
…ality [no changelog]
…e flash space [no changelog]
TychoVrahe
force-pushed
the
tychovrahe/T3T1/hw_support_framebuffer
branch
from
140bb5b
to
f881277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements framebuffer in internal RAM for T3T1, using ST7789V display driver.
Two framebuffers are used so that one can be used for drawing while the other is being transferred to display with DMA.
For maximum efficiency interrupts are used for starting the DMA transfers after tearing effect line signal.
Note: while this PR allows seamless switching of layouts without fading out-in, this is not changed in this PR and is considered out of scope here.
Builds on previous U5/T3T1 pull requests: #3370 #3422 #3466
This also fixes a bug in signing (bitcoin-like) tx flow, where after confirming the TX with hold to confirm, "loading transaction" loader is briefly shown and then fade-in/fade-out into "signing transaction" loader. This is specific to TT and HW only, because of originally missing
display_refreshcall in the progress init (TT does not need it to show the loader on display, while emulator and TS3 do)The ST7789V driver is getting quite complex with all the variations, maybe it would be better to split the implementation to F4 without framebuffer and U5 with framebuffer, the U5 variant wouldn't need to carry all the model T compatibility ifdefs so it would be somewhat cleaner